Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Changes with Redux Toolkit and Formatting Updates #1284

Open
wants to merge 49 commits into
base: development
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
5de009b
fixed CSV with previous changes
mikedivine Jun 20, 2024
62698fd
Finished formatting formatting CSV and updating tooltip data, tested …
mikedivine Jun 24, 2024
fe2117c
fixed csvUploadDefaults to remove create meter option
mikedivine Jun 25, 2024
1efb203
Merge branch 'development' into 1198-CSV
mikedivine Jun 26, 2024
bbcb164
fixed MetersCSVUpload to align to top of the page
rfrost30 Jun 27, 2024
2ed3395
formatted imports and file, fixed tooltip headings, fixed menu items …
mikedivine Jun 27, 2024
d10c158
only show create meter button if admin, made range a utlity and updat…
mikedivine Jun 29, 2024
70811ed
updated translation data
mikedivine Jun 29, 2024
0762368
updated CSV pipeline to use meterIdentifier instead of meterName to u…
mikedivine Jun 30, 2024
c5dcff3
fixed MetersCSVUpload to align to top of the page
rfrost30 Jul 7, 2024
d9ce247
updated translation to include meter identifier
rfrost30 Jul 7, 2024
cf90877
Updated CSV Readings to use only Refresh Readings and not Refresh hou…
mikedivine Jul 7, 2024
276dd0d
Updated CSV Readings and Meters to include validation and made fileRe…
mikedivine Jul 10, 2024
20860b7
fixes to allow Gzip files as well as csv files
mikedivine Jul 10, 2024
471ffd1
added some comments to readings component
mikedivine Jul 11, 2024
7d8718f
fix pipeline testing & bug
huss Jul 12, 2024
55e6595
updated server side upload Meters to send back the meter data that wa…
mikedivine Jul 14, 2024
796a7fd
took away "access to uploadMeters" from CSV users
mikedivine Jul 14, 2024
4c840e9
updated some requested changes for CSV Upload of meters and readings
mikedivine Jul 16, 2024
543fdbc
using lodash for range function
mikedivine Jul 17, 2024
215ccd5
Merge remote-tracking branch 'upstream/development' into 1198-CSV
mikedivine Jul 18, 2024
745d537
Made sure CSV Readings state is using it's own readingsData state and…
mikedivine Jul 19, 2024
350c51c
updated API return messages
mikedivine Jul 20, 2024
fdd332c
fixed csvPipeline Test Failures
mikedivine Jul 20, 2024
7a7cbb7
fix JSDoc
huss Jul 22, 2024
5312af8
next version now 2.0.0
huss Jul 22, 2024
a8665e6
fix csv API - put code inside try catch
mikedivine Jul 25, 2024
499f46d
updated changes to switch api back to not passing meters in. Fixed so…
mikedivine Jul 28, 2024
8065535
fixed import that wasn't used
mikedivine Jul 28, 2024
c1e89eb
Merge branch 'OpenEnergyDashboard:development' into 1198-CSV
mikedivine Jul 28, 2024
18bd44c
fixed newMeter set issue
mikedivine Jul 28, 2024
99a0f4b
updated to use invalidate on negative numbers
mikedivine Aug 1, 2024
0d37db6
Merge branch 'development' of https://github.com/OpenEnergyDashboard/…
mikedivine Aug 1, 2024
8e58a2d
accidentally removed a few lines, adding back in
mikedivine Aug 2, 2024
60f3c3b
finished api return updates
mikedivine Aug 2, 2024
045beed
altered CSV users from having limited meterData to having full access…
mikedivine Aug 2, 2024
124b17d
Switched to use TrueFalseType which is used in Meter components inste…
mikedivine Aug 2, 2024
3c26be4
fixed meters test since CSV users now also get all meterData along wi…
mikedivine Aug 3, 2024
7db5d54
Merge remote-tracking branch 'upstream/development' into 1198-CSV
mikedivine Aug 3, 2024
09c9f39
CSV Meters - If update is checked, then a Dropdown List of Meters is …
mikedivine Aug 3, 2024
a9b8a2b
fixed returned csv error type issue, needed to return the error.messa…
mikedivine Aug 3, 2024
518cc62
Revert "CSV Meters - fixed returned csv error type issue, needed to r…
mikedivine Aug 3, 2024
170951d
Removed form feedback on csv readings that is unused.
mikedivine Aug 3, 2024
659d42f
Merge remote-tracking branch 'origin/development' into pr/mikedivine/…
huss Aug 4, 2024
b8b5aae
fix merge syntax mistake
huss Aug 4, 2024
7e5db71
fix meters test merge issues
huss Aug 4, 2024
f54d7ae
meterName->meterIdentifier in pipeline tests
huss Aug 4, 2024
a38214f
Fixed CSV boolean paramter issues to allow for boolean, 'yes', 'no', …
mikedivine Aug 6, 2024
5e0b412
updated cumulative on Readings CSV component to disable it's associat…
mikedivine Aug 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
formatted imports and file, fixed tooltip headings, fixed menu items …
…grayed out if on that page
  • Loading branch information
mikedivine committed Jun 27, 2024
commit 2ed3395fa991c8582729f51f22097cef67a74339
10 changes: 6 additions & 4 deletions src/client/app/components/HeaderButtonsComponent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ export default function HeaderButtonsComponent() {
shouldGroupsButtonDisabled: true,
shouldMetersButtonDisabled: true,
shouldMapsButtonDisabled: true,
shouldCSVButtonDisabled: true,
shouldCSVMetersButtonDisabled: true,
shouldCSVReadingsButtonDisabled: true,
shouldUnitsButtonDisabled: true,
shouldConversionsButtonDisabled: true,
// Translated menu title that depend on whether logged in.
Expand Down Expand Up @@ -91,7 +92,8 @@ export default function HeaderButtonsComponent() {
shouldGroupsButtonDisabled: pathname === '/groups',
shouldMetersButtonDisabled: pathname === '/meters',
shouldMapsButtonDisabled: pathname === '/maps',
shouldCSVButtonDisabled: pathname === '/csv',
shouldCSVMetersButtonDisabled: pathname === '/csvMeters',
shouldCSVReadingsButtonDisabled: pathname === '/csvReadings',
shouldUnitsButtonDisabled: pathname === '/units',
shouldConversionsButtonDisabled: pathname === '/conversions'
}));
Expand Down Expand Up @@ -172,14 +174,14 @@ export default function HeaderButtonsComponent() {
</DropdownItem>
<DropdownItem
style={state.csvViewableLinkStyle}
disabled={state.shouldCSVButtonDisabled}
disabled={state.shouldCSVMetersButtonDisabled}
tag={Link}
to="/csvMeters">
<FormattedMessage id='csvMeters' />
</DropdownItem>
<DropdownItem
style={state.csvViewableLinkStyle}
disabled={state.shouldCSVButtonDisabled}
disabled={state.shouldCSVReadingsButtonDisabled}
tag={Link}
to="/csvReadings">
<FormattedMessage id='csvReadings' />
Expand Down
21 changes: 10 additions & 11 deletions src/client/app/components/csv/MetersCSVUploadComponent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@

mikedivine marked this conversation as resolved.
Show resolved Hide resolved
import * as React from 'react';
import { FormattedMessage } from 'react-intl';
import TooltipHelpComponent from '../TooltipHelpComponent';
import TooltipMarkerComponent from '../TooltipMarkerComponent';
import { useDispatch } from 'react-redux';
import { Button, Col, Container, Form, FormGroup, Input, Label, Row } from 'reactstrap';
import { showErrorNotification, showSuccessNotification } from '../../utils/notifications';
import FormFileUploaderComponent from '../FormFileUploaderComponent';
import { baseApi } from '../../redux/api/baseApi';
import { useDispatch } from 'react-redux';
import { uploadCSVApi } from '../../utils/api';
import { showErrorNotification, showSuccessNotification } from '../../utils/notifications';
import translate from '../../utils/translate';
import FormFileUploaderComponent from '../FormFileUploaderComponent';
import TooltipHelpComponent from '../TooltipHelpComponent';
import TooltipMarkerComponent from '../TooltipMarkerComponent';

interface MetersCSVUploadComponentProps {}
mikedivine marked this conversation as resolved.
Show resolved Hide resolved

Expand Down Expand Up @@ -75,20 +75,19 @@ const MetersCSVUploadComponent: React.FC<MetersCSVUploadComponentProps> = () =>
};

const checkBox = {
display: 'flex',
alignItems: 'center'
display: 'flex'
};

return (
mikedivine marked this conversation as resolved.
Show resolved Hide resolved
<Container style={{ minHeight: '100vh' }}>
<TooltipHelpComponent page='help.csv.header' />
<Container>
mikedivine marked this conversation as resolved.
Show resolved Hide resolved
<TooltipHelpComponent page='help.csv.meters' />
<Form onSubmit={handleSubmit}>
<Row className="justify-content-center">
<Row className="justify-content-md-center">
mikedivine marked this conversation as resolved.
Show resolved Hide resolved
<Col md='auto'>
<h2>
{translate('csv.upload.meters')}
<div style={tooltipStyle}>
<TooltipMarkerComponent page='help.csv.header' helpTextId={tooltipStyle.tooltipReadings} />
<TooltipMarkerComponent page='help.csv.meters' helpTextId={tooltipStyle.tooltipReadings} />
</div>
</h2>
</Col>
Expand Down
30 changes: 15 additions & 15 deletions src/client/app/components/csv/ReadingsCSVUploadComponent.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,20 @@

import * as React from 'react';
mikedivine marked this conversation as resolved.
Show resolved Hide resolved
import { Button, Col, Container, Form, FormGroup, Input, Label, Row } from 'reactstrap';
import TooltipHelpComponent from '../TooltipHelpComponent';
import TooltipMarkerComponent from '../TooltipMarkerComponent';
import { BooleanMeterTypes, TimeSortTypes, ReadingsCSVUploadPreferencesItem } from '../../types/csvUploadForm';
import { authApi, authPollInterval } from '../../redux/api/authApi';
import { useAppSelector } from '../../redux/reduxHooks';
import { selectVisibleMeterAndGroupData } from '../../redux/selectors/adminSelectors';
import { selectIsAdmin } from '../../redux/slices/currentUserSlice';
import { BooleanMeterTypes, ReadingsCSVUploadPreferencesItem, TimeSortTypes } from '../../types/csvUploadForm';
import { MeterData } from '../../types/redux/meters';
import { uploadCSVApi } from '../../utils/api';
import { ReadingsCSVUploadDefaults } from '../../utils/csvUploadDefaults';
import { showErrorNotification, showInfoNotification } from '../../utils/notifications';
import translate from '../../utils/translate';
import FormFileUploaderComponent from '../FormFileUploaderComponent';
import { uploadCSVApi } from '../../utils/api';
import TooltipHelpComponent from '../TooltipHelpComponent';
import TooltipMarkerComponent from '../TooltipMarkerComponent';
import CreateMeterModalComponent from '../meters/CreateMeterModalComponent';
import { useAppSelector } from '../../redux/reduxHooks';
import { authApi, authPollInterval } from '../../redux/api/authApi';
import { selectIsAdmin } from '../../redux/slices/currentUserSlice';
import { selectVisibleMeterAndGroupData } from '../../redux/selectors/adminSelectors';
import { MeterData } from '../../types/redux/meters';

/**
* Returns a range of values between the specified lower and upper bounds.
Expand All @@ -34,7 +34,7 @@ function range(lower: number, upper: number): number[] {
}

mikedivine marked this conversation as resolved.
Show resolved Hide resolved
/**
mikedivine marked this conversation as resolved.
Show resolved Hide resolved
* Defines the CSV Readings page card view
* Defines the CSV Readings page
* @returns CSV Readings page element
*/
export default function ReadingsCSVUploadComponent() {
Expand Down Expand Up @@ -66,7 +66,7 @@ export default function ReadingsCSVUploadComponent() {
setSelectedMeter(createdMeter);
}
}
}, [createdMeterIdentifier,visibleMeters]);
}, [createdMeterIdentifier, visibleMeters]);

const handleFileChange = (file: File | null) => {
setSelectedFile(file);
Expand All @@ -82,7 +82,7 @@ export default function ReadingsCSVUploadComponent() {
}));
};

const handleChange = (e:React.ChangeEvent<HTMLInputElement | HTMLTextAreaElement>) => {
const handleChange = (e: React.ChangeEvent<HTMLInputElement | HTMLTextAreaElement>) => {
const { name, value } = e.target;
setReadingsData(prevState => ({
...prevState,
Expand Down Expand Up @@ -147,14 +147,14 @@ export default function ReadingsCSVUploadComponent() {

return (
<Container>
<TooltipHelpComponent page='help.csv.header' />
<TooltipHelpComponent page='help.csv.readings' />
<Form onSubmit={handleSubmit}>
<Row className="justify-content-md-center">
<Col md='auto'>
<h2>
{translate('csv.upload.readings')}
<div style={tooltipStyle}>
<TooltipMarkerComponent page='help.csv.header' helpTextId={tooltipStyle.tooltipReadings} />
<TooltipMarkerComponent page='help.csv.readings' helpTextId={tooltipStyle.tooltipReadings} />
</div>
</h2>
</Col>
Expand All @@ -178,7 +178,7 @@ export default function ReadingsCSVUploadComponent() {
</Input>
</Label>
<br />
<CreateMeterModalComponent onCreateMeter={handleCreateMeter}/>
<CreateMeterModalComponent onCreateMeter={handleCreateMeter} />
<br /><br />
<FormGroup>
mikedivine marked this conversation as resolved.
Show resolved Hide resolved
<Label for='timeSort'>
Expand Down
Loading