Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-qt-client] Stop using Qt 5.15.2 in the CI #19049

Merged

Conversation

MartinDelille
Copy link
Contributor

@MartinDelille MartinDelille commented Jul 2, 2024

After reviewing #18893, I noticed the current ci was broken (see my first commit ci result).

I propose to remove 5.15.2 support that is not easily accessible directly from the Qt Maintenance tool. For information, The code compiles fine on 5.15.9 on my local machine.

I propose to simplify the Qt CI workflow by removing test against 5.15.2.

cc @ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd @wing328

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@MartinDelille MartinDelille marked this pull request as ready for review July 2, 2024 14:20
@MartinDelille MartinDelille changed the title [cpp-qt-client] Just for test [cpp-qt-client] Stop using Qt 5.15.2 in the CI Jul 2, 2024
@muttleyxd
Copy link
Contributor

Makes sense to me. Let's merge!

@wing328 wing328 merged commit aef9142 into OpenAPITools:master Jul 7, 2024
15 checks passed
@wing328 wing328 added this to the 7.8.0 milestone Jul 7, 2024
@MartinDelille MartinDelille deleted the cpp-qt-minor-modification branch July 9, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants