Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-fetch] Fix API-generation of referenced enums for multipart/form-data #19016

Merged

Conversation

Masamas
Copy link
Contributor

@Masamas Masamas commented Jun 25, 2024

Adds isEnumRef to the condition because it does not match the isPrimitiveType condition if the enum definition is separated.
isEnumRef was also added to the typescript-fetch specific ExtendedCodegenParameter and ExtendedCodegenProperty so that it can be used in templates.

Fixes #11613

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Masamas Masamas changed the title [typescript-fetch] Fix API-generation of referenced enums [typescript-fetch] Fix API-generation of referenced enums for multipart/form-data Jun 25, 2024
Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks for your contribution!

@macjohnny
Copy link
Member

please re-generate the samples according to the instructions in the PR description

@Masamas
Copy link
Contributor Author

Masamas commented Jul 2, 2024

@macjohnny
Sorry, I only saw some whitespace differences and wasn't sure if those were relevant.
I added the newly generated samples.

@macjohnny macjohnny merged commit 5d61f71 into OpenAPITools:master Jul 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] typescript-fetch casts enum scalar values to Blob
2 participants