Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring & remove unused variables, parameters, fields and assignments #18806

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented May 31, 2024

Lots of cleanup – not only get rid of a handful of squiggles in my IDE, but also making code more concise.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Philzen Philzen marked this pull request as draft May 31, 2024 12:31
@Philzen Philzen force-pushed the change/simplify-code branch 3 times, most recently from f0bde49 to c0c089b Compare June 2, 2024 20:46
@Philzen Philzen marked this pull request as ready for review June 2, 2024 20:46
@Philzen Philzen marked this pull request as draft June 3, 2024 04:36
Replace with Collections.singletonList(), Collections.emptyList(), or List.of()
the latter depending on whether content is guaranteed to be constant).
This will save some memory.

In particular, Collections.emptyList() and List.of() with no arguments always
return a shared instance, while Arrays.asList() with no arguments creates a
new object every time it's called.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant