Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11737 Add package to bean name in converter.mustache for EnumConverterConfiguration.java #17738

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Tomschi
Copy link

@Tomschi Tomschi commented Jan 29, 2024

Add package to bean name in converter.mustache for EnumConverterConfiguration.java to resolve issue #17737

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Feb 5, 2024

can you please follow step 3 to update the samples?

@wing328
Copy link
Member

wing328 commented Feb 7, 2024

cc
@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

@MelleD
Copy link
Contributor

MelleD commented Feb 12, 2024

A test that shows the problem would be great

@MelleD
Copy link
Contributor

MelleD commented Feb 12, 2024

Here we have a similar issue with the Configuration names:
#17847

Also possible is to remove the @configuration Annotation and we use directly the @import from spring and then everyone can decide where and when the Config will be loaded.

@Tomschi
Copy link
Author

Tomschi commented Feb 23, 2024

A test that shows the problem would be great

I don't think, that there is any useful test. It is the same like the @bean definition.

@Tomschi
Copy link
Author

Tomschi commented Jul 2, 2024

Here is an example to reproduce the issue: https://github.com/Tomschi/openapi-generator-issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants