Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Real-Time tracking of active users in an operation #2437

Conversation

workaryangupta
Copy link
Contributor

@workaryangupta workaryangupta commented Jul 16, 2024

This pull request aims to introduce a new feature to mscolab that allows a user to see the current number of active users in an operation.

sss

@ReimarBauer
Copy link
Member

ReimarBauer commented Jul 17, 2024

I think the output should be near by the operation name: Description Active Users: 2

currently it is on the title line describing operations at all.

@ReimarBauer
Copy link
Member

ReimarBauer commented Jul 17, 2024

When a user gets removed from the activated OP this needs an update of the counter

removing_user_role_from_active_op.mp4

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently the size of the description changes the space of the label for the active users.

image

The activity counter has a precendence over a long description which is good. The border could have a bit more space.

image

I am also not sure if the word Users: would be enough (without the word Active)

@workaryangupta
Copy link
Contributor Author

currently the size of the description changes the space of the label for the active users.
Fixed it

@ReimarBauer
Copy link
Member

Please update your branch with develop

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReimarBauer ReimarBauer merged commit fb41b66 into Open-MSS:GSOC2024-AryanGupta Aug 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants