Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace pytz usage with zoneinfo module #2280

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

Myrausman
Copy link
Contributor

@Myrausman Myrausman commented Mar 14, 2024

Fixes #2279

Checklist:

  • Bug fix. Fixes Remove the pytz dependency #2279
  • New feature (Non-API breaking changes that adds functionality)
  • PR Title follows the convention of <type>: <subject>
  • Commit has unit tests

@ReimarBauer
Copy link
Member

not everything is a bug. refactoring usually is more like an enhancement.

@@ -47,7 +47,6 @@ requirements:
- netcdf4
- hdf4
- pillow
- pytz
Copy link
Member

@ReimarBauer ReimarBauer Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was in the past wrong to add it here. Seems we needed it only for development.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@Myrausman Myrausman changed the title fix: Replace pytz usage with zoneinfo module refactor : Replace pytz usage with zoneinfo module Mar 15, 2024
@matrss matrss changed the title refactor : Replace pytz usage with zoneinfo module refactor: Replace pytz usage with zoneinfo module Mar 18, 2024
@matrss matrss merged commit de7d336 into Open-MSS:develop Mar 18, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the pytz dependency
3 participants