feat: added an amount of good to destinguish colors #2143 #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AryanBakliwal <[email protected]>
ReimarBauer
reviewed
Mar 4, 2024
ReimarBauer
reviewed
Mar 4, 2024
|
A colleague changed the colors for a plot to
|
ReimarBauer
reviewed
Mar 6, 2024
| @@ -44,11 +44,45 @@ | |||
| WMS = 0 | |||
|
|
|||
|
|
|||
| class CustomColorDialog(QtWidgets.QColorDialog): | |||
There was a problem hiding this comment.
that is now doubling the code lines,
there should be only one definition, you can move it to
mpl_qtwidget and import it then.
|
usually the tests done in 5mins now it gets into a timeout at 10mins. That is a bit strange. |
|
This is not changed in the PR it is shown to solve the test issue. sigkill on the test where it gets stuck shows: |
matrss
reviewed
Mar 11, 2024
Comment on lines
+140
to
+145
| Colors | ||
| ------ | ||
|
|
||
| We utilize custom colors for distinguishing routes using the color palette provided by SashaMaps. | ||
| Link: https://sashamaps.net/docs/resources/20-colors/ | ||
|
|
There was a problem hiding this comment.
This was inserted in the middle of the "Identity Provider" section, i.e. above and below is stuff about pysaml2. It should not split that section.
matrss
reviewed
Mar 11, 2024
Comment on lines
+76
to
+77
| def getColor(self, button): | ||
| return QtGui.QPalette(button.palette()).color(QtGui.QPalette.Button) |
There was a problem hiding this comment.
This seems to do something different than the default getColor method of QColorDialog that is being overridden. Is it possible to drop this and use the class as CustomColorDialog.getColor(colour), i.e. how the QColorDialog class was previously used as well?
The CI timeout is happening because some tests mock the QColorDialog.getColor method, which now no longer works as intended and instead leaves the widget open, which blocks the tests from finishing.
|
the issue was solved differently during GSOC-2024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?: To add good to distinguish colors
Fixes #2143
The predefined color swatches in QColorDialog are typically determined by the system's color scheme or the default color palette. Unfortunately, PyQt5's QColorDialog does not provide a direct method to modify these predefined color swatches.
I created a custom dialog that mimics the behavior of the QColorDialog to customize the color swatches.
Previous dialog
New dialog
