Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor : Used urljoin instead of string concatenation #2240

Merged
merged 6 commits into from
Feb 26, 2024
Merged

refactor : Used urljoin instead of string concatenation #2240

merged 6 commits into from
Feb 26, 2024

Conversation

Myrausman
Copy link
Contributor

Fixes #1929
Used urljoins instead of '+' operation and f' string.

Checklist:

  • Bug fix. Fixes always use urljoin #1929
  • New feature (Non-API breaking changes that adds functionality)
  • PR Title follows the convention of <type>: <subject>
  • Commit has unit tests

ReimarBauer
ReimarBauer requested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@ReimarBauer ReimarBauer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

have a look also on tests.

e.g. in test_mscolab

create_msui_settings_file('{"MSS_auth": {"' + self.url + '": "[email protected]"}}')

.....

false ;)

@ReimarBauer ReimarBauer self-requested a review February 26, 2024 13:33
ReimarBauer
ReimarBauer approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@ReimarBauer ReimarBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@ReimarBauer ReimarBauer merged commit b8a200d into Open-MSS:develop Feb 26, 2024
4 checks passed
ReimarBauer pushed a commit to ReimarBauer/MSS that referenced this pull request Mar 12, 2024
@Myrausman @ReimarBauer
refactor : Used urljoin instead of string concatenation (Open-MSS#2240)
8982a0c 
Signed-off-by: Myrausman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReimarBauer ReimarBauer ReimarBauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

always use urljoin
2 participants
@Myrausman @ReimarBauer