Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: rescope distributed validator pubkey during slice iteration #1802

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

gsora
Copy link
Collaborator

@gsora gsora commented Feb 13, 2023

Fixes the issue where during a create cluster workflow with more than one distributed validator, only the last key in the pubkey slice was used for them all.

This should fix compose tests 500 errors as well.

category: bug
ticket: none

Fixes the issue where during a `create cluster` workflow with more than one distributed validator, only the last key in the pubkey slice was used for them all.

This should fix compose tests 500 errors as well.
@gsora gsora added the bug Something isn't working label Feb 13, 2023
@gsora gsora self-assigned this Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 55.00% // Head: 55.13% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (787dbb2) compared to base (9483de1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1802      +/-   ##
==========================================
+ Coverage   55.00%   55.13%   +0.12%     
==========================================
  Files         168      168              
  Lines       22043    22010      -33     
==========================================
+ Hits        12125    12135      +10     
+ Misses       8352     8312      -40     
+ Partials     1566     1563       -3     
Impacted Files Coverage Δ
cmd/createcluster.go 55.36% <100.00%> (+0.09%) ⬆️
app/vmock.go 76.16% <0.00%> (ø)
cmd/relay.go 0.00% <0.00%> (ø)
cmd/cmd.go 81.73% <0.00%> (+0.77%) ⬆️
core/qbft/qbft.go 83.19% <0.00%> (+0.84%) ⬆️
core/scheduler/scheduler.go 77.34% <0.00%> (+1.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gsora gsora added the merge when ready Indicates bulldozer bot may merge when all checks pass label Feb 13, 2023
@obol-bulldozer obol-bulldozer bot merged commit 039fe15 into main Feb 13, 2023
@obol-bulldozer obol-bulldozer bot deleted the gsora/fix_createcluster branch February 13, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants