Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: adds debug logs for metric issue #1791

Merged
merged 1 commit into from
Feb 10, 2023
Merged

p2p: adds debug logs for metric issue #1791

merged 1 commit into from
Feb 10, 2023

Conversation

corverroos
Copy link
Contributor

Adds debug logs to identify invalid p2p_peer_connection_types metric values.

category: bug
ticket: #1790

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 55.01% // Head: 54.95% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (451962e) compared to base (f6e660f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1791      +/-   ##
==========================================
- Coverage   55.01%   54.95%   -0.06%     
==========================================
  Files         167      167              
  Lines       22005    22024      +19     
==========================================
- Hits        12106    12104       -2     
- Misses       8336     8357      +21     
  Partials     1563     1563              
Impacted Files Coverage Δ
p2p/p2p.go 17.27% <0.00%> (-1.91%) ⬇️
app/vmock.go 74.09% <0.00%> (-2.08%) ⬇️
app/app.go 60.16% <0.00%> (-0.65%) ⬇️
app/eth2wrap/synthproposer.go 66.35% <0.00%> (+0.31%) ⬆️
core/scheduler/scheduler.go 77.34% <0.00%> (+1.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@corverroos corverroos added the merge when ready Indicates bulldozer bot may merge when all checks pass label Feb 10, 2023
@obol-bulldozer obol-bulldozer bot merged commit 7c0b207 into main Feb 10, 2023
@obol-bulldozer obol-bulldozer bot deleted the corver/debugp2p branch February 10, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready Indicates bulldozer bot may merge when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants