Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shoal mask #1170

Open
wants to merge 28 commits into
base: dev
Choose a base branch
from
Open

Add shoal mask #1170

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
064d465
Mask utils
ruxandra-valcu Aug 22, 2023
9ef9de9
rename
ruxandra-valcu Aug 22, 2023
ca783b5
Mask utils
ruxandra-valcu Aug 22, 2023
f4224b3
Weill shoal mask
ruxandra-valcu Aug 22, 2023
3cbb721
Decided against implementing the echoview method
ruxandra-valcu Aug 22, 2023
4b1d878
Turned out not to need these
ruxandra-valcu Aug 22, 2023
1c3dcd9
Add wrapper function
ruxandra-valcu Aug 23, 2023
67f3fbf
ci(deps): Bump actions/cache from 3.3.1 to 3.3.2 (#1161)
dependabot[bot] Sep 12, 2023
54917f2
chore(deps): [pre-commit.ci] pre-commit autoupdate (#1162)
pre-commit-ci[bot] Sep 12, 2023
6c58a1e
Refactoring and adding channel selection capability
ruxandra-valcu Sep 15, 2023
6012c1e
Import fix
ruxandra-valcu Sep 19, 2023
debb7c6
ci: Bump docker/setup-qemu-action from 2 to 3 (#1172)
dependabot[bot] Sep 19, 2023
2c45181
ci: Bump docker/login-action from 2 to 3 (#1175)
dependabot[bot] Sep 19, 2023
f42b722
ci: Bump docker/build-push-action from 4 to 5 (#1173)
dependabot[bot] Sep 19, 2023
7ec7a1c
ci: Bump docker/setup-buildx-action from 2 to 3 (#1174)
dependabot[bot] Sep 19, 2023
8cbb01d
Merge branch 'main' into feature/add-shoal-mask
ruxandra-valcu Sep 20, 2023
daefe93
Delinting
ruxandra-valcu Sep 20, 2023
1762a05
Requirements consistency
ruxandra-valcu Oct 10, 2023
663510e
Refactoring
ruxandra-valcu Oct 10, 2023
c6e35da
Merge/dev (#115)
ruxandra-valcu Nov 7, 2023
ffee09e
Merge dev (#124)
ruxandra-valcu Nov 13, 2023
2664759
Rewrote weill shoal method to use xarray+dask
ruxandra-valcu Nov 13, 2023
e62b3dd
Fixed a test
ruxandra-valcu Nov 13, 2023
27da72a
Fixed a test
ruxandra-valcu Nov 13, 2023
7905e13
Denoise fix
ruxandra-valcu Nov 24, 2023
0c6e4bb
Requirements
ruxandra-valcu Nov 24, 2023
e24a01e
Fixed an array issue
ruxandra-valcu Dec 6, 2023
538d7b9
Fixed an array issue
ruxandra-valcu Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed a test
  • Loading branch information
@ruxandra-valcu
ruxandra-valcu committed Nov 13, 2023
commit e62b3ddc75acffd05f8ff1d12bc9a613d14a3452
3 changes: 2 additions & 1 deletion echopype/tests/mask/test_mask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,8 @@ def test_apply_mask_channel_variation(source_has_ch, mask_has_ch):

def test_shoal_mask_all(sv_dataset_jr161):
source_Sv = sv_dataset_jr161
ml= echopype.mask.api.get_shoal_mask_multichannel(
ml = echopype.mask.api.get_shoal_mask_multichannel(
source_Sv, method="will", parameters=ep.mask.shoal.WEILL_DEFAULT_PARAMETERS
)
assert np.all(ml["channel"] == source_Sv["channel"])