Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updateds to readme #2

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Updateds to readme #2

merged 1 commit into from
Mar 15, 2017

Conversation

caoyler
Copy link
Contributor

@caoyler caoyler commented Mar 15, 2017

Please double check my clarifications all look right. Thanks!

@amontenegro
Copy link
Member

Great @caoyler! thanks for fixing the links!


* Required:
* p: Local path where you want to place the ORCID data dump
* Optional:
* f: The public data dump is provided in two different formats XML and JSON, the default one is XML
* v: The public data dump is provided in the two main API versions, 1.2 and 2.0, the default one is 2.0
* f: Format, the public data dump is provided in two different formats XML and JSON, the default one is XML
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to use the word "dump" here? @caoyler, @rcpeters asked to change it for "sync" but I dont know if sync sounds weird here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed most of the times we use "dump" to "sync" but skipped this one and a few others where I thought it sounded weird. I figure @rcpeters only really cares about the title. But if we're changing it everywhere, we probably shouldn't call the script dump.py!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, in my next push I will change the name of the script to sync.py, I hope to push something in an hour or two

@amontenegro amontenegro merged commit 8683230 into master Mar 15, 2017
@amontenegro amontenegro deleted the ReadmeUpdates branch March 20, 2017 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants