Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test framework to deveDependencies #24

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

csachs
Copy link
Contributor

@csachs csachs commented May 3, 2018

Installing the single-file bibtex-parse-js currently loads over 100 other packages, due to ava.

By moving ava to the devDependencies, it should only be loaded when development/testing is desired.

xml2js seems to be unused at all?

Pushing this as PR to see if Travis CI properly installs the package with devDependencies enabled.

@hubgit
Copy link

hubgit commented Oct 20, 2019

Please merge this - the test framework shouldn't be part of the dependencies when installing this package.

@rcpeters
Copy link
Contributor

@wjrsimpson @lizkrznarich

@lizkrznarich lizkrznarich merged commit 37b23d2 into ORCID:master Oct 24, 2019
@robtree
Copy link

robtree commented Nov 30, 2020

I've created #30 as it would be very helpful for this change to be published to NPM:

https://www.npmjs.com/package/bibtex-parse-js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants