Hyrax 1295 -draft #942
Merged
Hyrax 1295 -draft #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mrpp file. Also start adding code to read special structure data from the dmrpp file.
…de according to sonar cloud. Clean up unused code.
|
|
|
jgallagher59701
approved these changes
Jun 11, 2024
| bool ret_value = true; | ||
| Constructor::Vars_iter vi = var_ctor->var_begin(); | ||
| Constructor::Vars_iter ve = var_ctor->var_end(); | ||
| for (; vi != ve; vi++) { |
There was a problem hiding this comment.
If you use the const vector<BaseType*> &variables() const { return d_vars; } method, these loops can be re-written using the range-based for loop:
for (auto bt: var_ctor->variables()) {
...
}
| Constructor::Vars_iter vi = dmrpp_s->var_begin(); | ||
| Constructor::Vars_iter ve = dmrpp_s->var_end(); | ||
|
|
||
| for (; vi != ve; vi++) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make dmrpp to support the access of Structure that contains strings(variable or fixed length) as the base type.