Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved all 'unused' code to top level retired directory #935

Merged
merged 2 commits into from
May 31, 2024

Conversation

ndp-opendap
Copy link
Contributor

@ndp-opendap ndp-opendap commented May 29, 2024

Our BES code base is loaded with unused (aka retired) code that makes using CLion hard because search is always identifying this dead code. By placing these unused things in a top level directory, retired, we can easily exclude that directory from CLion searches and still keep the things around for later... Or we could just dump them all...

Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dh-opendap
Copy link
Contributor

Seems logical to me. There are too many files to review individually, all tests are passing so I'd approve.

Copy link
Contributor

@dh-opendap dh-opendap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great idea. All tests look to be passing. Approved.

Copy link
Member

@jgallagher59701 jgallagher59701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long overdue! Thanks. Merge.

@ndp-opendap ndp-opendap merged commit edfb632 into master May 31, 2024
2 checks passed
@ndp-opendap ndp-opendap deleted the dump_unused branch May 31, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants