fix: 4D series loaded in basic mode #4232 #4294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev canceled.
|
✅ Deploy Preview for ohif-platform-docs canceled.
|
sedghi
reviewed
Jul 19, 2024
sedghi
reviewed
Jul 22, 2024
| const { | ||
| toolGroupService, | ||
| syncGroupService, | ||
| segmentationService, | ||
| cornerstoneViewportService, | ||
| } = servicesManager.services; | ||
|
|
||
| // Turn 4D mode off to move back to its initial state. | ||
| volumeLoaderUtil.disable4DMode(); |
There was a problem hiding this comment.
This situation is somewhat concerning. What's the reason for it? If it's truly necessary, we should implement a service with an onModeExit method to ensure it always runs.
There was a problem hiding this comment.
There is a call to enable4DMode() on line 55 in onModeEnter and this call to disable4DMode() here in onModeExit because 4D will be enabled only for this mode otherwise the viewer will try to split any series into a 4D series.
|
I don't think we need this anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
4D series was not loading in basic mode because the image ids were being split into time points even though all images should be loaded in a stack viewport ("normal mode").
Changes & Results
4D mode is disabled until preclinical 4D mode is started when it set 4D mode to
true. OnceTesting
Load the study shared here and make sure it loads in basic mode.