Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to build ExpandableToolMenu ToolbarRows recursively. #2611

Open
wants to merge 4 commits into
base: v2-legacy
Choose a base branch
from

Conversation

andrewwebbdeveloper
Copy link

  • Add ability to build ExpandableToolMenu ToolbarRows recursively.
  • Allows any number of sub-menus ( configured from the toolbarModule ).

PR Checklist

  • Brief description of changes
  • Links to any relevant issues
  • Required status checks are passing
  • User cases if changes impact the user's experience
  • @mention a maintainer to request a review

-Allows any number of sub-menus ( configured from the toolbarModule ) and they will still work.
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #2611 (74acd56) into master (1e72684) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2611      +/-   ##
==========================================
- Coverage   13.20%   13.13%   -0.07%     
==========================================
  Files         289      289              
  Lines        7816     7854      +38     
  Branches     1510     1514       +4     
==========================================
  Hits         1032     1032              
- Misses       5474     5508      +34     
- Partials     1310     1314       +4     
Impacted Files Coverage Δ
platform/core/src/classes/StudyPrefetcher.js 0.69% <0.00%> (-0.03%) ⬇️
...latform/core/src/classes/metadata/StudyMetadata.js 1.29% <0.00%> (-0.02%) ⬇️
.../src/studies/services/wado/studyInstanceHelpers.js 2.04% <0.00%> (-0.19%) ⬇️
...form/core/src/utils/isDisplaySetReconstructable.js 3.37% <0.00%> (ø)
...r/src/connectedComponents/ConnectedStudyBrowser.js 0.00% <0.00%> (ø)
...tform/viewer/src/connectedComponents/ToolbarRow.js 0.00% <0.00%> (ø)
platform/viewer/src/connectedComponents/Viewer.js 0.00% <0.00%> (ø)
...tform/viewer/src/connectedComponents/ViewerMain.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79548d2...74acd56. Read the comment docs.

@sedghi sedghi self-requested a review December 23, 2021 17:08
@sedghi
Copy link
Member

sedghi commented Dec 23, 2021

Thanks for your PR and contribution.
I tried it with level 3 nested buttons and it doesn't behave as expected, see below

2021-12-23.16-08-37.mp4

@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale 🥖 label Jul 10, 2022
@sedghi sedghi removed the Stale 🥖 label Jan 11, 2023
@sedghi sedghi changed the base branch from master to v2-legacy June 19, 2023 13:20
@sedghi
Copy link
Member

sedghi commented Jun 19, 2023

base has changed, read more here #3477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2-legacy OHIF v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants