Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hssi: suggest hssi{loopback,stats} when eth interface is absent #3117

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

pcolberg
Copy link
Contributor

@pcolberg pcolberg commented Apr 11, 2024

While the D5005 FPGA card employs a separate kernel driver (s10hssi) to configure loopback and provide statistics via a network device, newer FPGA cards expose a UIO device used with hssiloopback and hssistats.

Closes: https://hsdes.intel.com/appstore/article/#/22019839240

Cc: @badanur

@pcolberg pcolberg self-assigned this Apr 11, 2024
@pcolberg pcolberg requested a review from a team as a code owner April 11, 2024 21:52
While the D5005 FPGA card employs a separate kernel driver (s10hssi) to
configure loopback and provide statistics via a network device, newer
FPGA cards expose a UIO device used with hssiloopback and hssistats.

Closes: https://hsdes.intel.com/appstore/article/#/22019839240
Signed-off-by: Peter Colberg <[email protected]>
@pcolberg pcolberg changed the title hssi: suggest hssi{loopback,stats} command when eth interface is absent hssi: suggest hssi{loopback,stats} when eth interface is absent Apr 11, 2024
@coveralls
Copy link

coveralls commented Apr 11, 2024

Pull Request Test Coverage Report for Build 8653758794

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.673%

Totals Coverage Status
Change from base Build 8653071263: 0.0%
Covered Lines: 15823
Relevant Lines: 24466

💛 - Coveralls

@fpgamatt
Copy link
Contributor

This change is helpful because it adds information to a weird error message, but can't we do better? Can't the hssi command figure out if the hssi in question is d5005 or a uio? That way no weird message would need to be printed out in the first place.

@pcolberg
Copy link
Contributor Author

pcolberg commented Apr 11, 2024

This change is helpful because it adds information to a weird error message, but can't we do better? Can't the hssi command figure out if the hssi in question is d5005 or a uio? That way no weird message would need to be printed out in the first place.

Thanks @fpgamatt, my thought as well; why was this functionality not integrated into the hssi command in the first place? That requires a bit more investigation; I have opened #3118.

@pcolberg pcolberg merged commit afb66cd into master Apr 11, 2024
30 checks passed
@pcolberg pcolberg deleted the pcolberg/s10hssi branch April 11, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants