opae.io: Fix error handling when binding the vfio-pci driver fails #3095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7818328836
💛 - Coveralls |
fpgamatt
reviewed
Feb 7, 2024
binaries/opae.io/opae/io/utils.py
Outdated
| @@ -145,6 +145,10 @@ def vfio_init(pci_addr, new_owner='', force=False, **kwargs): | |||
| msg = '(0x{:04x},0x{:04x}) at {}'.format( | |||
| int(vid_did[0], 16), int(vid_did[1], 16), pci_addr) | |||
|
|
|||
| if not iommu_enabled(): | |||
| LOG.error("IOMMU is disabled. Binding failed.") | |||
| raise SystemExit("IOMMU is disabled") | |||
There was a problem hiding this comment.
The LOG.error message is not exactly correct because the binding "will" fail. How about "Binding to vfio-pci will fail because IOMMU is disabled."
Does the Log.error call and the raise SystemExit result in two messages being printed? We only need error message and a non-zero exit.
|
Can we improve the commit message to something like the following? opae.io: Fix error handling when binding the vfio-pci driver fails The 'opae.io init' command can fail to bind the vfio-pci driver when the IOMMU is disabled, leaving the system seemingly unable to bind another driver. The fix is to check if the IOMMU is enabled before even attempting to bind the vfio-pci driver. |
The 'opae.io init' command can fail to bind the vfio-pci driver when the IOMMU is disabled, leaving the system seemingly unable to bind another driver. The fix is to check if the IOMMU is enabled before even attempting to bind the vfio-pci driver. Signed-off-by: anandaravuri <[email protected]>
c7125b3
to
000d54d
Compare
fpgamatt
approved these changes
Feb 7, 2024
pcolberg
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'opae.io init' command can fail to bind the vfio-pci driver when the IOMMU is disabled, leaving the system seemingly unable to bind another driver. The fix is to check if the IOMMU is enabled before even attempting to bind the vfio-pci driver.