Continuous Integration tests up and running #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now I have deactivated the Documentation action for GitHub, we can provide them in the future once the API is stable. I have also reduced the number of glaciers in the tests from 12 to 5, since it downloads a ton of data on GitHub CI.
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one took a lot of effort. Setting up the continuous integration to work correctly with the Python environment AND PyCall was hard. On top of this, there was a nasty error related to the SSL certificate which prevented the Python libraries to fetch data from urls.
The tests are still very slow, because of #115, which prevents GitHub Actions to successfully cache the precompiled Julia files. Fixing this should shave 20 mins off this. On top of this, there is no way around having to download all the files for the initial state of glaciers. Particularly the surface velocity files which are pretty big. For now, I have reduced the number of glaciers in the test from 12 to 5 to speed this up.
Now that this infrastructure is running, we can progressively add new tests to improve the coverage. But this provides at least some basic coverage for the main workflows related to the solving of the PDE.
I have also updated the README with instructions on how to correctly setup the Python environment using micromamba, as it is done in the CI.