Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the initial work on extending generateDS' GdsCollector to offer more helpful help messages.
This replaces the buildin
parse/parseString
methods with variants that know about the filename (and passes it on to OcrdGdsCollector.OcrdGdsCollector should probably have the same interface, i.e. inherit from ValidationReport (which needs to support an alias
add_message
->add_error
).Now that the foundations are here, we can discuss what kind of information should be captured and how messages should be formatted.