Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] project_milestone_spent_hours #1333

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

abenzbiria
Copy link

Context

The module project_milestone <https://github.com/OCA/project/tree/14.0/project_milestone>_ allows to define milestones for a project.

Multiple tasks in the project can be linked to a given milestone.

Field total hours is displayed in form and list view of a project milestone and in tab of milestones of a project

Description

Field Total Hours is the sum of timesheets of active tasks associated to the milestone

[IMP] Code quality

[IMP] Code quality

[IMP] Code quality

[IMP] Code quality

[CHG] Copyright text

[CHG] Dependency

[FIX] Unit test updating milestone with no project

[FIX] Unit test updating milestone with no project

[FIX] Unit test updating milestone with no project

[CHG] Test on force compute

[FIX] Unit test updating milestone with no project

[FIX] Unit test updating milestone with no project

[FIX] Active field on project.milestone

[ADD] readme
@abenzbiria
Copy link
Author

Hi Hi @aleuffre , @leemannd , @OCA/project-service-maintainers

Could you review this PR please?

Have a nice day

@abenzbiria abenzbiria changed the title TA#65338 [14.0][ADD] project_milestone_spent_hours [14.0][ADD] project_milestone_spent_hours Aug 30, 2024
@TumbaoJu
Copy link

TumbaoJu commented Sep 9, 2024

@OCA/project-service-maintainers : Hello! Can you please revise this PR? Thank you in advance.

)

def write(self, vals):
res = super(ProjectMilestone, self).write(vals)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use simply super()

@rvalyi
Copy link
Member

rvalyi commented Sep 12, 2024

important: after Odoo v15, project_milestone is removed from the OCA as it became a native feature. so not sure it's worth adding this module in v14. See #1268

@TumbaoJu
Copy link

important: after Odoo v15, project_milestone is removed from the OCA as it became a native feature. so not sure it's worth adding this module in v14. See #1268

Thank you for your comment but we think and know that a lot of people are using V14 so we think that it could be good to have those new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants