Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX][l10n_it_declaration_of_intent] fix domain wizard #3324

Merged
merged 2 commits into from
Jun 14, 2023
Merged

[FIX][l10n_it_declaration_of_intent] fix domain wizard #3324

merged 2 commits into from
Jun 14, 2023

Conversation

matteoopenf
Copy link
Contributor

No description provided.

@matteoopenf matteoopenf mentioned this pull request May 23, 2023
Closed
3 tasks
@matteoopenf matteoopenf force-pushed the 14.0-fix-active-declaration_show branch from faadca8 to 2dc5d2f Compare May 23, 2023 08:07
@matteoopenf matteoopenf marked this pull request as ready for review May 23, 2023 08:07
amosdisabatino
amosdisabatino approved these changes May 23, 2023
View reviewed changes
l10n_it_declaration_of_intent/wizard/select_declarations.py Outdated
@@ -30,6 +30,9 @@ def _default_declaration(self):
("date_end", ">=", invoice.invoice_date),
]
domain = expression.AND([domain, date_domain])

domain.append(("state", "not in", ["close", "expired"]))
Copy link

@amosdisabatino amosdisabatino May 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matteoopenf non so qui, ma altre volte usavamo le tuple

@matteoopenf matteoopenf force-pushed the 14.0-fix-active-declaration_show branch from 6fa35b0 to e840076 Compare May 23, 2023 16:45
@matteoopenf matteoopenf force-pushed the 14.0-fix-active-declaration_show branch from e840076 to b3f3802 Compare May 23, 2023 16:46
@matteoopenf
Copy link
Contributor Author

@tafaRU per caso occorre altro o e' pronta per il merge?

@matteoopenf
Copy link
Contributor Author

@tafaRU ho diviso i due fix in due commit, dimmi pure se devo unirli o se cosi' com'e' va bene.
Grazie Mille

andreampiovesana
andreampiovesana approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andreampiovesana
andreampiovesana approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tafaRU
Copy link
Member

tafaRU commented May 26, 2023

@andreampiovesana l'hai testata su runboat?

@matteoopenf
Copy link
Contributor Author

@andreampiovesana ci siamo?

@matteoopenf
Copy link
Contributor Author

@andreampiovesana se ci siamo che cosi poi richiedo il merge
Grazie Mille

@matteoopenf
Copy link
Contributor Author

matteoopenf commented Jun 14, 2023 •
edited
Loading

@andreampiovesana puoi dare il feedback? Grazie Mille

@andreampiovesana
Copy link
Contributor

@andreampiovesana l'hai testata su runboat?

image
ok

@matteoopenf
Copy link
Contributor Author

@tafaRU possiamo procedere a questo punto direi

@tafaRU
Copy link
Member

tafaRU commented Jun 14, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-3324-by-tafaRU-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 14, 2023
@OCA-git-bot
Merge PR #3324 into 14.0
4b18bff 
Signed-off-by tafaRU
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-3324-by-tafaRU-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 834f45c into OCA:14.0 Jun 14, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e667e07. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreampiovesana andreampiovesana andreampiovesana approved these changes

@lorenzoallegrucci lorenzoallegrucci lorenzoallegrucci approved these changes

@amosdisabatino amosdisabatino amosdisabatino approved these changes

@patrickt-oforce patrickt-oforce patrickt-oforce approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@matteoopenf @tafaRU @andreampiovesana @OCA-git-bot @lorenzoallegrucci @amosdisabatino @patrickt-oforce