Use openupgrade lib and warn old use #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0b0e4a
to
69c64bb
Compare
5d429ab
to
a68f4d6
Compare
|
I haven't tested this version yet in a real migration, but it seems to be correct. |
|
👍 |
StefanRijnhart
added a commit
that referenced
this pull request
Sep 21, 2015
Use openupgrade lib and warn old use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.0 version
Reopen of #317 on my own branch
We ported the openupgrade scripts to pypi
The recommendation for using those scripts is now:
from openupgradelib import openupgradeThis patch should properly raise a warning be reverse compatible as long as openupgradelib is intalled in the python path.
The reasoning behind moving this bit of code to a lib is for module migrations within the same Odoo version but with changes in a module such as a field rename.
Prior to this, the recommended way was to copy code into migrations if not use OpenUpgrade. This makes the code reusable and gets rid of code duplication.