Clarify Link Obj parameters as best we can (3.0.4) #3824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handrews
added
links
clarification
miqui
previously approved these changes
May 21, 2024
ralfhandl
reviewed
May 23, 2024
ralfhandl
previously approved these changes
May 23, 2024
This acknowledges the ambiguity in the key and value syntax of the Link Object's `parameter` field, and provides a bit of guidance on how to implement it. Sadly it is not possible to fully solve in a point release.
|
@ralfhandl @lornajane @darrelmiller I have substantially condensed this PR based on this morning's TDC call - the new text should get the essentials across and be more clear. |
ralfhandl
reviewed
May 24, 2024
Co-authored-by: Ralf Handl <[email protected]>
ralfhandl
approved these changes
May 27, 2024
lornajane
approved these changes
Jun 4, 2024
This was referenced Jun 4, 2024
miqui
added a commit
that referenced
this pull request
Jun 6, 2024
Clarify Link Obj parameters as best we can (3.1.1 port of #3824)
lornajane
added a commit
that referenced
this pull request
Jun 6, 2024
Clarify Link Obj parameters as best we can (3.2.0 port of #3824)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
This acknowledges the ambiguity in the key and value syntax of the Link Object's
parameterfield, and provides a bit of guidance on how to implement it. Sadly it is not possible to fully solve in a point release.