Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle urls without quotes and with semicolon #3

Merged
merged 1 commit into from
Sep 10, 2017

Conversation

lykahb
Copy link

@lykahb lykahb commented Sep 10, 2017

In the previous PR I broke the case when urls don't have quotes and have weird symbols inside. The fix is to try to parse values with quotes first, then without.

This is a testcase for the fix

#Categories li, .bullet-list li, .location-depth-3 li {
    background-image: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAQAAAAEBAMAAABb34NNAAAAFVBMVEXyrmHqcBDtdQ3pcRHcbRkAAAD/uSmYi/+cAAAABnRSTlORbFE2DwAwkbURAAAAEUlEQVQI12MIEmEwSwAiIAMAC/AB+fq6WIgAAAAASUVORK5CYII=);
    background-repeat: no-repeat
}

@NxtChg NxtChg merged commit dfea099 into NxtChg:master Sep 10, 2017
@NxtChg
Copy link
Owner

NxtChg commented Sep 10, 2017

Thank you, good catch.

@NxtChg
Copy link
Owner

NxtChg commented Sep 10, 2017

Hey, are you on reddit? Or do you have BTC/BCC address? I feel like I should thank you with something more tangible :)

@lykahb
Copy link
Author

lykahb commented Sep 10, 2017

I have a BTC wallet 1NGxD7QgSYgWmuFSi7yKbWMGH4f9cA1dTK. Thank you for the library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants