Fix bug around handling security advisories with 100 or more affected packages #9279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… packages The original implementation used a securityAdvisory(databaseId) query which no longer exists. This switches to using GHSA ID as the parameter.
zhhyu
approved these changes
Oct 19, 2022
RiadGahlouz
reviewed
Oct 19, 2022
| type | ||
| value | ||
| } | ||
| securityAdvisory(ghsaId: " + JsonConvert.SerializeObject(advisory.GhsaId) + @") { |
There was a problem hiding this comment.
Any reason we're not directly using string interpolation and have to pass the value to SerializeObject?
There was a problem hiding this comment.
If we use string interpolation, we'll need to escape the curly brackets which are part of the GraphQL query. So, either string concatenation with no curly escaping, or string interpolation with curly escaping. I think the string concatenation is a bit more readable.
drewgillies
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation used a
securityAdvisory(databaseId)query which no longer exists. This switches to using GHSA ID as the parameter.Fixes https://github.com/NuGet/Engineering/issues/4619.