Not null the createdby on delete account #6808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristinamanum
requested review from
chenriksson,
shishirx34,
zhhyu,
scottbommarito,
skofman1,
loic-sharma,
agr,
ryuyu and
joelverhagen
| @@ -20,6 +20,8 @@ public class SupportRequestService | |||
| private IAuditingService _auditingService; | |||
| private readonly string _siteRoot; | |||
| private const string _unassignedAdmin = "unassigned"; | |||
| private const string _deletedAccount = "_deletedaccount"; | |||
| private const string _NuGetDSRAccount = "_NuGetDSR"; | |||
There was a problem hiding this comment.
We should have a unit test in the registration flow asserting that this account name is not a valid account name.
We picked the underscore prefix because today this cannot be an actual username.
There was a problem hiding this comment.
Added unit tests for the username regex verification.
joelverhagen
approved these changes
Jan 10, 2019
loic-sharma
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On delete account the issue. createdby field will be obfuscated but not changed to null . The issues will be marked as resolved and still be visible on the support page.