Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SCrypt #709

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for SCrypt #709

wants to merge 1 commit into from

Conversation

bcantin
Copy link

@bcantin bcantin commented Aug 2, 2015

No description provided.

@arnvald
Copy link
Collaborator

arnvald commented Sep 18, 2015

Hi @bcantin

thanks for the PR! I'll review the code next week and probably I'll ask some questions, since I haven't worked with SCrypt myself yet.

Also, could you change this code so that scrypt gem is loaded only when user chooses this algorithm? The reason is that I'm trying to make Sorcery work both on MRI and JRuby, and this gem provides native extension only for MRI, so loading it will fail on JRuby.

@bcantin
Copy link
Author

bcantin commented Sep 18, 2015

Sure thing. I'll do that later next week as I am visiting some family this
week

On Fri, 18 Sep 2015 at 12:32 Grzegorz Witek [email protected]
wrote:

Hi @bcantin https://github.com/bcantin

thanks for the PR! I'll review the code next week and probably I'll ask
some questions, since I haven't worked with SCrypt myself yet.

Also, could you change this code so that scrypt gem is loaded only when
user chooses this algorithm? The reason is that I'm trying to make Sorcery
work both on MRI and JRuby, and this gem provides native extension only for
MRI, so loading it will fail on JRuby.


Reply to this email directly or view it on GitHub
#709 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants