add --update-rpath to change between RPATH and RUNPATH #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Apr 23, 2023
| @@ -79,6 +79,10 @@ the "/foo/lib" reference instead of the "/tmp" entry. | |||
| .IP --print-rpath | |||
| Prints the DT_RUNPATH or DT_RPATH for an executable or library. | |||
|
|
|||
| .IP --update-rpath | |||
| Updates the DR_RPATH to a DT_RUNTPATH or vice versa if "--force-rpath" is given | |||
There was a problem hiding this comment.
Can you elaborate on when you want to set the one over the other?
There was a problem hiding this comment.
They have slightly different semantics as detailed in man ld-linux. Would saying that + linking to the other manpage be ok? Or should I add a small summary?
There was a problem hiding this comment.
I think this get a different name. It's already confusing that we say --print-rpath and it's actually printing the DT_RUNPATH. "Update" might be also the wrong verb as it convert from DR_RPATH to a DT_RUNPATH, whereas update clashes already with --set-rpath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you!
Please do your best to include a regression test
so that the quality of future releases can be preserved.