Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the largest segment alignment for libraries requiring non-standard alignments #474 #475

Merged
merged 2 commits into from
Mar 11, 2023
Merged

Use the largest segment alignment for libraries requiring non-standard alignments #474 #475

merged 2 commits into from
Mar 11, 2023

Conversation

brenoguim
Copy link
Collaborator

@brenoguim brenoguim commented Mar 5, 2023 •
edited
Loading

It turns out libraries can have a larger than usual alignment on their LOAD segments. Patchelf should try to play along and use the largest alignment if its going to add a new LOAD segment

@brenoguim brenoguim changed the title Breno.474 Add ARM to the list that requires 0x10000 alignment #474 Mar 5, 2023
@brenoguim brenoguim mentioned this pull request Mar 5, 2023
Closed
@brenoguim brenoguim force-pushed the breno.474 branch 3 times, most recently from a344645 to 637f96b Compare March 7, 2023 22:30
@brenoguim brenoguim changed the title Add ARM to the list that requires 0x10000 alignment #474 Use the alignment of the largest segment for libraries requiring non-standard alignments #474 Mar 7, 2023
@brenoguim brenoguim changed the title Use the alignment of the largest segment for libraries requiring non-standard alignments #474 Use the largest segment alignment alignmen for libraries requiring non-standard alignments #474 Mar 8, 2023
@brenoguim brenoguim changed the title Use the largest segment alignment alignmen for libraries requiring non-standard alignments #474 Use the largest segment alignment for libraries requiring non-standard alignments #474 Mar 8, 2023
@brenoguim brenoguim marked this pull request as ready for review March 8, 2023 00:18
Mic92
Mic92 reviewed Mar 8, 2023
View reviewed changes
tests/set-rpath-library.sh Outdated Show resolved Hide resolved
@brenoguim @Mic92
Filter with awk instead of grep
80f6866 
Co-authored-by: Jörg Thalheim <[email protected]>
@brenoguim brenoguim merged commit ac212d0 into NixOS:master Mar 11, 2023
@brenoguim brenoguim deleted the breno.474 branch March 11, 2023 13:59
@Mic92 Mic92 mentioned this pull request Apr 24, 2023
Open
@matoro matoro mentioned this pull request Aug 22, 2023
Open
@mika-fischer mika-fischer mentioned this pull request Nov 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brenoguim @Mic92