Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.nvim-compe: deprecate for nvim-cmp #357347

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Conversation

khaneliman
Copy link
Contributor

Things done

While going through all the plugins and requires testing. I noticed the nvim-compe plugin has been archived for a couple years and all development moved to nvim-cmp.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@khaneliman khaneliman changed the title vimPlugins.{compe}: deprecate for nvim-cmp vimPlugins.nvim-compe: deprecate for nvim-cmp Nov 19, 2024
@@ -2604,7 +2579,8 @@ in
};

tmux-complete-vim = super.tmux-complete-vim.overrideAttrs {
dependencies = with self; [ nvim-compe ];
# Vim plugin with optional nvim-compe lua module
doCheck = false;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically does nothing until #352277 is implemented.

Copy link
Member

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was surprised to see nvim-compe extensions in your other PR 😅
LGTM.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 19, 2024
nvim-compe has been replaced with nvim-cmp
nvim-compe has been replaced with nvim-cmp
nvim-compe has been replaced with nvim-cmp
nvim-compe has been replaced with nvim-cmp
nvim-compe has been replaced with nvim-cmp
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 20, 2024
@teto
Copy link
Member

teto commented Nov 20, 2024

not ruling out there are still users out there (I see it mentioned sometimes on neovim chat), who I encourage to test other solutions.

@teto teto merged commit a9da88a into NixOS:master Nov 20, 2024
10 of 11 checks passed
@khaneliman khaneliman deleted the compe branch November 20, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants