-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dart: fix nativeBuildInputs, buildInputs and env are not accesible in… #356777
base: master
Are you sure you want to change the base?
dart: fix nativeBuildInputs, buildInputs and env are not accesible in… #356777
Conversation
I got several hashes error of flutter-engine-source while running |
359b39a
to
e2b53ce
Compare
…6: fix hash sources
@philiptaron After this change I'm getting error some errors while running nixpkgs review. However I think is not caused by my changes. |
How did you update the hashes? Did you use the update script? The update script is broken after the |
@RossComputerGuy, I run nix develop --unpack .#flutterPackages-source.v3_24 and once unpack failed caused of wrong hash. I replaced with correct hash. The same with 3_26 and 3_27. |
Ok because the |
@RossComputerGuy I replace all hashes which match the incorrect hash, if you want I could leave aarch64-linux unchanged. |
I'm just skeptical if this PR changes things correctly. I have opened a PR to fix the hashes + updater. |
@RossComputerGuy Fine, let me know once is merged to rebase changes and remove the hashes changes from my branch :) |
nativeBuildInputs
,buildInputs
andenv
attributes has been added to dart package generator. The lack of this attributes cause that if aconfigure
script is found in the repository may will fail because of the lack of dependencies or correct environment variable setup.This change will trigger several applications rebuild.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.