Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart: fix nativeBuildInputs, buildInputs and env are not accesible in… #356777

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

erikeah
Copy link
Contributor

@erikeah erikeah commented Nov 17, 2024

nativeBuildInputs, buildInputs and env attributes has been added to dart package generator. The lack of this attributes cause that if a configure script is found in the repository may will fail because of the lack of dependencies or correct environment variable setup.

This change will trigger several applications rebuild.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@erikeah
Copy link
Contributor Author

erikeah commented Nov 17, 2024

I got several hashes error of flutter-engine-source while running nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD", Could I update the hash mismatch in this PR?

@erikeah erikeah force-pushed the buildFlutterApplication/nativeBuildInputs-are-not-available-in-configurePhase branch from 359b39a to e2b53ce Compare November 18, 2024 09:09
@erikeah
Copy link
Contributor Author

erikeah commented Nov 19, 2024

@philiptaron After this change I'm getting error some errors while running nixpkgs review. However I think is not caused by my changes.

@RossComputerGuy
Copy link
Member

Could I update the hash mismatch in this PR?

How did you update the hashes? Did you use the update script? The update script is broken after the *Platform -> stdenv.*Platform PR.

@erikeah
Copy link
Contributor Author

erikeah commented Nov 19, 2024

@RossComputerGuy, I run nix develop --unpack .#flutterPackages-source.v3_24 and once unpack failed caused of wrong hash. I replaced with correct hash. The same with 3_26 and 3_27.

@RossComputerGuy
Copy link
Member

Ok because the aarch64-linux / aarch64-linux ones shouldn't have changed.

@erikeah
Copy link
Contributor Author

erikeah commented Nov 19, 2024

@RossComputerGuy I replace all hashes which match the incorrect hash, if you want I could leave aarch64-linux unchanged.

@RossComputerGuy
Copy link
Member

I'm just skeptical if this PR changes things correctly. I have opened a PR to fix the hashes + updater.

@erikeah
Copy link
Contributor Author

erikeah commented Nov 21, 2024

@RossComputerGuy Fine, let me know once is merged to rebase changes and remove the hashes changes from my branch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants