mamelon: init at 3.3.5 #343995
Open
mamelon: init at 3.3.5 #343995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aleksanaa
reviewed
Sep 24, 2024
pkgs/data/fonts/mamelon/default.nix
Outdated
| homepage = "https://moji-waku.com"; | ||
| license = lib.licenses.gpl3Plus; | ||
| platforms = lib.platforms.all; | ||
| maintainers = [ ]; |
There was a problem hiding this comment.
We don't allow adding package without maintainers now. See https://github.com/NixOS/nixpkgs/tree/master/pkgs#new-packages
There was a problem hiding this comment.
I can maintain it. But as for the versioning, if there exists only a single version of this package...do I leave it at 1? (the version in the commit is what I now realize to be the font weight...)
There was a problem hiding this comment.
0-unstable-yyyy-mm-dd in publishing date, or whatever if you don't really know.
added 2 commits
September 23, 2024 22:11
Aleksanaa
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Also this non-standard directory is not allowed for new single package. See pkgs/by-name
Aleksanaa
reviewed
Oct 31, 2024
Co-authored-by: Aleksana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added font -mamelon- to nixpkgs
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.