Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pixelorama: copy icon during install phase #326543

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

Iorvethe
Copy link
Contributor

Copying the icon to share/icons allows for DEs such as KDE or GNOME to pick it up and show it in desktop entries.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Maintainers

@felschr


Add a 👍 reaction to pull requests you find important.

Copying the icon to `share/icons` allows for DEs such as KDE or
GNOME to pick it up and show it in desktop entries.
@felschr
Copy link
Member

felschr commented Jul 12, 2024

Result of nixpkgs-review pr 326543 run on x86_64-linux 1

1 package built:
  • pixelorama

@felschr felschr added the backport release-24.05 Backport PR automatically label Jul 12, 2024
@Artturin Artturin merged commit 4120b62 into NixOS:master Jul 12, 2024
29 of 31 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants