-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GNOME updates 2024-07-03 #324341
GNOME updates 2024-07-03 #324341
Conversation
Thanks. Changes look okay, here is a few things I noticed:
No arrow.
Deprecation of two functions is weard in a patch version but probably should not be an obstacle for backport.
https://gitlab.gnome.org/GNOME/gnome-control-center/-/commit/51bf36ac68051aaf183c1aa0b45b8af7cc479c70 sounds like an easy way to skip some tests, maybe upstream should use Also the
👍 Looks like it used
I think that is used by tests, which we do not run, so it is not relevant for now. Also, you are right, GNOME Shell only switched to Jasmine from jsUnit last month, so the commit message is probably unchanged from the cherry-picked commit. Also looks like it removes |
https://gitlab.gnome.org/GNOME/gnome-control-center/-/compare/46.2...46.3 Some tests are now disabled if Xvfb is missing, I imagine we don't need xvfb-run when the X11SessionTestCase helper actually takes care of X and system/session bus. https://gitlab.gnome.org/GNOME/gnome-control-center/-/commit/51bf36ac68051aaf183c1aa0b45b8af7cc479c70
https://gitlab.gnome.org/GNOME/gnome-initial-setup/-/compare/46.2...46.3 I don't know why we need to set PKG_CONFIG_SYSTEMD_SYSUSERSDIR so I just dropped it, it looks like the prefix is properly replaced in upstream's meson.build via pkgconfig_define.
python3.pkgs.python-dbusmock | ||
setxkbmap | ||
xvfb-run | ||
xorgserver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment it is for Xvfb?
Interestingly, it has been used since 3.29 (PR for dbusmock inclusion pending).
https://gitlab.gnome.org/GNOME/gnome-shell/-/compare/46.2...46.3.1 I am mostly confused by b9b5f9a, actually I don't think we need jasmine-gjs in 46.x. Dropping gtk3 and libstartup_notification: https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/27b9985da3f4e098e1bb9aa27a15d9151af7efc4 Verified that gtk3 is really not needed by `grep -nr '3\.0'` in src. While at it explicitly add libX11 and libxml2 as direct deps.
Thanks. |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)