Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skia: init, ladybird: 0-unstable-2024-06-08 -> 0-unstable-2024-07-01 #324050

Closed
wants to merge 3 commits into from

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jul 2, 2024

Description of changes

We need to update icu to 7.4 flobally before merging this. I temporarily bumped it in this pr and marked as draft. I will bump icu in staging, then undraft this.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fgaz
Copy link
Member Author

fgaz commented Jul 2, 2024

I thought ofborg wouldn't request reviews on draft prs. Maybe I'm mistaking that with CODEOWNERS? Anyway, sorry for the ping everyone. I'm closing this and will open separate PRs.

edit: looks like icu was already bumped on staging (#290509). great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant