Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-web: 0.3.0 -> 0.4.2 #321563

Merged
merged 2 commits into from
Jun 22, 2024
Merged

nix-web: 0.3.0 -> 0.4.2 #321563

merged 2 commits into from
Jun 22, 2024

Conversation

liclac
Copy link
Contributor

@liclac liclac commented Jun 21, 2024

Description of changes

https://codeberg.org/gorgon/gorgon/releases/tag/nix-web-v0.4.2

Things done

Updated nix-web from v0.3.0 to v0.4.2.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@matteo-pacini
Copy link
Contributor

Does not compile on aarch64-darwin, perhaps we can remove it from platforms.unix until it is fixed?

       >   = note: ld: framework not found SystemConfiguration
       >           clang-16: error: linker command failed with exit code 1 (use -v to see invocation)
       >
       >
       > error: could not compile `nix-web` (bin "nix-web") due to 1 previous error

@liclac
Copy link
Contributor Author

liclac commented Jun 21, 2024

Does not compile on aarch64-darwin, perhaps we can remove it from platforms.unix until it is fixed?

       >   = note: ld: framework not found SystemConfiguration
       >           clang-16: error: linker command failed with exit code 1 (use -v to see invocation)
       >
       >
       > error: could not compile `nix-web` (bin "nix-web") due to 1 previous error

I'll do you one better and see if I can fix it. I added a dependency on SystemConfiguration.framework on Darwin, does that work for you? I don't have any Darwin machines to test it on myself, but nothing else about the software should be Linux specific.

@matteo-pacini
Copy link
Contributor

matteo-pacini commented Jun 21, 2024

Super, testing it now!

Copy link
Contributor

@matteo-pacini matteo-pacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liclac

Result of nixpkgs-review pr 321563 run on aarch64-darwin 1

1 package built:
  • nix-web

Well done 💯 tested the binary also, LGTM

@Aleksanaa Aleksanaa merged commit 0bb47ac into NixOS:master Jun 22, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants