-
-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catppuccin-gtk: use vendored colloid-gtk-theme #321293
Conversation
We used to replace vendored colloid-gtk-theme with our nixpkgs version, but catppuccin-gtk has been archived, and its patches cannot be applied on recent version of colloid-gtk-theme, so we dropped it. We may deprecate catppuccin-gtk in favor of the catppuccin flavor of colloid-gtk-theme (which was introduced in 2024-06-18), but still needs some user feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to fix the issue 👍
If we're going through with this PR, after how long do we deprecate it? I assume development will only take place in Colloid from now on. |
Maybe a few months? There is no need to remove this kind of thing immediately, we can wait and see for a while |
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current derivation doesn't provide any theme output, this is fixing the derivation to actually work again. |
I'd prefer not to remove it for the foreseeable future since catppuccin/gtk though dead still supports catppuccin better than colloid since it supports the full 4 themes and all accents, as well as an OLED tweak, none of which colloid does. Though catppuccin-gtk should be removed at some point... |
Is collooid a proper replacement though? I don't think you can pick a a variant and flavor there, e.g. macchiato + maroon |
Doesn't seem so, only thing I could find is comment in issue asking for Catppuccin in the first place that it wasn't available and asking for it but no issue or anything tracking it directly |
It's done, and I've updated colloid |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/gtk-settings-suddenly-not-applying/47381/5 |
We used to replace vendored colloid-gtk-theme with our nixpkgs version, but catppuccin-gtk has been archived, and its patches cannot be applied on recent version of colloid-gtk-theme, so we dropped it. We may deprecate catppuccin-gtk in favor of the catppuccin flavor of colloid-gtk-theme (which was introduced in 2024-06-18), but still needs some user feedback.
Description of changes
Fixes #315143 (comment)
Related #320681
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.