mailmanPackages.python3: fix markdown support #321136
Conversation
Fixes the issue reported at https://gitlab.com/mailman/mailman/-/issues/1137. The readme-renderer package needs cmarkgfm for markdown support. Mailman's postorious needs this to render the info field of mailing lists.
|
Successfully created backport PR for |
|
|
||
| readme-renderer = super.readme-renderer.overridePythonAttrs (_: { | ||
| propagatedBuildInputs = [ self.cmarkgfm ]; | ||
| }); |
There was a problem hiding this comment.
What? Why do we only add this for mailman, and not the general readme-renderer package?
We were about to be able to eliminate the last remaining override…
There was a problem hiding this comment.
38 hours is also not a lot of time to leave for maintainer review…
There was a problem hiding this comment.
Sorry for merging this myself.
The dependency is an optional feature and not strictly required for readme_renderer: https://github.com/pypa/readme_renderer/blob/main/pyproject.toml#L34-L35. Since mailman does require this feature, I thought it would be fitting to add this to the overrides instead of adding the dependency to readme_renderer to follow upstream.
Any other suggestions?
There was a problem hiding this comment.
buildPythonPackage has a mechanism to express optional-dependencies, so I think we'd just use that.
https://nixos.org/manual/nixpkgs/unstable/#buildpythonpackage-parameters
Description of changes
Fixes the issue reported at https://gitlab.com/mailman/mailman/-/issues/1137. The readme-renderer package needs cmarkgfm for markdown support. Mailman's postorious needs this to render the info field of mailing lists.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.