-
-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vgmtrans: init at 1.1-unstable-2024-07-31 #321129
base: master
Are you sure you want to change the base?
Conversation
Getting a build error:
|
Hmmm... it's quite interesting to me that it's |
repo = "vgmtrans"; | ||
rev = "9de4c06b03f8c9ec9ecb5c81dfcb53d1b8f75bbe"; | ||
hash = "sha256-689ceDbQrifH64eA79fCpa+eB70gJYKSyiZDlC1HZiA="; | ||
fetchSubmodules = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please devendor the deps from https://github.com/vgmtrans/vgmtrans/blob/master/.gitmodules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would make the derivation a lot more complicated as it expects these libraries' source code to be installed at specific locations. Would try this later if I have time
|
||
nativeBuildInputs = [ | ||
cmake | ||
autoPatchelfHook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this if we build from source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the libbass vgmtrans shipped with. The one in Nixpkgs has been marked broken for a very long time and the project expects it to be dynamically linked.
in | ||
'' | ||
# Make the bundled libbass visible to autoPatchelfHook | ||
install -D ../lib/bass/${dylibs} -t $out/lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
install -D ../lib/bass/${dylibs} -t $out/lib | |
install -D ../lib/bass/${sharedLibs} -t $out/lib |
dylibs is darwin specific
meta = { | ||
description = "Tool to convert proprietary, sequenced videogame music to industry-standard formats"; | ||
homepage = "https://github.com/vgmtrans/vgmtrans"; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libpng | ||
bsd3 # oki_adpcm_state | ||
]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of changes
Fixes #319631.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.