Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vgmtrans: init at 1.1-unstable-2024-07-31 #321129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pluiedev
Copy link
Contributor

Description of changes

Fixes #319631.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@keenanweaver
Copy link
Member

Getting a build error:

error:
       … while querying the derivation named 'vgmtrans-1.1-unstable-2024-06-16'

       … while calling the 'getAttr' builtin

         at /builtin/derivation.nix:19:19: (source not available)

       … while calling the 'derivationStrict' builtin

         at /builtin/derivation.nix:9:12: (source not available)

       … while evaluating derivation 'vgmtrans-1.1-unstable-2024-06-16'
         whose name attribute is located at /home/keenan/.cache/nixpkgs-review/pr-321129-3/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:334:7

       … while evaluating attribute 'postInstall' of derivation 'vgmtrans-1.1-unstable-2024-06-16'

         at /home/keenan/.cache/nixpkgs-review/pr-321129-3/nixpkgs/pkgs/by-name/vg/vgmtrans/package.nix:32:3:

           31|
           32|   postInstall =
             |   ^
           33|     let

       … from call site

         at /home/keenan/.cache/nixpkgs-review/pr-321129-3/nixpkgs/pkgs/by-name/vg/vgmtrans/package.nix:36:11:

           35|         lib.optionalString stdenv.isAarch64 "aarch64/"
           36|         + lib.optionalString stdenv.isUnix "lib"
             |           ^
           37|         + "bass{,midi}"

       … while calling 'optionalString'

         at /home/keenan/.cache/nixpkgs-review/pr-321129-3/nixpkgs/lib/strings.nix:268:5:

          267|     # String to return if condition is true
          268|     string: if cond then string else "";
             |     ^
          269|

       error: attribute 'isUnix' missing

       at /home/keenan/.cache/nixpkgs-review/pr-321129-3/nixpkgs/pkgs/by-name/vg/vgmtrans/package.nix:36:30:

           35|         lib.optionalString stdenv.isAarch64 "aarch64/"
           36|         + lib.optionalString stdenv.isUnix "lib"
             |                              ^
           37|         + "bass{,midi}"
https://github.com/NixOS/nixpkgs/pull/321129 failed to build: Failed to list packages: nix-env failed with exit code 1

@pluiedev
Copy link
Contributor Author

Hmmm... it's quite interesting to me that it's stdenv.isAarch64 but stdenv.*hostPlatform*.isUnix. Oh well, fixing

repo = "vgmtrans";
rev = "9de4c06b03f8c9ec9ecb5c81dfcb53d1b8f75bbe";
hash = "sha256-689ceDbQrifH64eA79fCpa+eB70gJYKSyiZDlC1HZiA=";
fetchSubmodules = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make the derivation a lot more complicated as it expects these libraries' source code to be installed at specific locations. Would try this later if I have time


nativeBuildInputs = [
cmake
autoPatchelfHook
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this if we build from source?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the libbass vgmtrans shipped with. The one in Nixpkgs has been marked broken for a very long time and the project expects it to be dynamically linked.

in
''
# Make the bundled libbass visible to autoPatchelfHook
install -D ../lib/bass/${dylibs} -t $out/lib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
install -D ../lib/bass/${dylibs} -t $out/lib
install -D ../lib/bass/${sharedLibs} -t $out/lib

dylibs is darwin specific

meta = {
description = "Tool to convert proprietary, sequenced videogame music to industry-standard formats";
homepage = "https://github.com/vgmtrans/vgmtrans";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

libpng
bsd3 # oki_adpcm_state
];

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: vgmtrans
3 participants