vgmtrans: init at 1.1-unstable-2024-07-31 #321129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting a build error: |
|
Hmmm... it's quite interesting to me that it's |
| repo = "vgmtrans"; | ||
| rev = "9de4c06b03f8c9ec9ecb5c81dfcb53d1b8f75bbe"; | ||
| hash = "sha256-689ceDbQrifH64eA79fCpa+eB70gJYKSyiZDlC1HZiA="; | ||
| fetchSubmodules = true; |
There was a problem hiding this comment.
Please devendor the deps from https://github.com/vgmtrans/vgmtrans/blob/master/.gitmodules
There was a problem hiding this comment.
That would make the derivation a lot more complicated as it expects these libraries' source code to be installed at specific locations. Would try this later if I have time
|
|
||
| nativeBuildInputs = [ | ||
| cmake | ||
| autoPatchelfHook |
There was a problem hiding this comment.
Why do we need this if we build from source?
There was a problem hiding this comment.
Because of the libbass vgmtrans shipped with. The one in Nixpkgs has been marked broken for a very long time and the project expects it to be dynamically linked.
| in | ||
| '' | ||
| # Make the bundled libbass visible to autoPatchelfHook | ||
| install -D ../lib/bass/${dylibs} -t $out/lib |
There was a problem hiding this comment.
Suggested change
| install -D ../lib/bass/${dylibs} -t $out/lib | |
| install -D ../lib/bass/${sharedLibs} -t $out/lib |
dylibs is darwin specific
| meta = { | ||
| description = "Tool to convert proprietary, sequenced videogame music to industry-standard formats"; | ||
| homepage = "https://github.com/vgmtrans/vgmtrans"; | ||
|
|
| libpng | ||
| bsd3 # oki_adpcm_state | ||
| ]; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #319631.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.