graalvm-oracle: init at 22 #321026
Open
graalvm-oracle: init at 22 #321026
+53
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farnoy
commented
Jun 19, 2024
pkgs/top-level/all-packages.nix
Outdated
| graalvmCEPackages = | ||
| recurseIntoAttrs (callPackage ../development/compilers/graalvm/community-edition { }); | ||
| graalvm-ce = graalvmCEPackages.graalvm-ce; | ||
| graalvm-oracle = callPackage ../development/compilers/graalvm/oracle { }; |
There was a problem hiding this comment.
This used to be called GraalVM EE, now just "Oracle GraalVM". Maybe oracle-graalvm would be a better name here?
ofborg
bot
requested review from
hlolli,
thiagokokada,
bennyandresen,
ericdallo and
glittershark
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #259639, resolves #259631
Description of changes
This adds oracle-graalvm and make buildGraalvm more generic to be used on other places than community-edition.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Pinging @thiagokokada (reviewer from the previous PR)
Add a 👍 reaction to pull requests you find important.