python3Packages.flet: fix flet by nix run complaining about missing flet #320913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 4 packages built:
|
Artturin
reviewed
Jun 27, 2024
Comment on lines
66
to
69
| fixupPhase = '' | ||
| wrapProgram $out/bin/flet \ | ||
| --prefix PYTHONPATH : $PYTHONPATH | ||
| ''; |
There was a problem hiding this comment.
Suggested change
| fixupPhase = '' | |
| wrapProgram $out/bin/flet \ | |
| --prefix PYTHONPATH : $PYTHONPATH | |
| ''; | |
| makeWrapperArgs = [ | |
| "--prefix PYTHONPATH : $PYTHONPATH" | |
| ]; |
However, I can't reproduce the import error because bin/.flet-wrapped already contains a line like this
import sys;import site;import functools;sys.argv[0] = '/nix/store/6ynbyvrzxy5g7maa7w8xm5mhxz23kmvv-python3.11-flet-0.22.1/bin/flet';functools.reduce(lambda k, p: site.addsitedir(p, k), ['/nix/store/6ynbyvrzxy5g7maa7w8xm5mhxz23kmvv-python3.11-flet-0.22.1/lib/python3.11/site-packages','/nix/store/4akqnwj2agnmf7jpr2w782d76yaalzfs-python3.11-fastapi-0.110.2/lib/python3...$ ./result/bin/flet
usage: flet [-h] [--version] {create,run,pack,publish,build} ...
positional arguments:
{create,run,pack,publish,build}
create Create a new Flet app from a template.
run Run Flet app.
pack Package Flet app to a standalone bundle.
publish Publish Flet app as a standalone web app.
build Build an executable app or install bundle.
options:
-h, --help show this help message and exit
--version show program's version number and exit
There was a problem hiding this comment.
Try with any example from https://github.com/flet-dev/examples
There was a problem hiding this comment.
It only happens when you actually open a example, --help works for me too.
There was a problem hiding this comment.
Please try to find out why the additional wrapping is needed, ask in the nix python matrix channel if needed.
Signed-off-by: lucasew <[email protected]>
lucasew
force-pushed
the
20240618-fix-flet
branch
from
215f978
to
161f6b0
Compare
|
Result of 4 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
If one runs flet by using nix run it complains about missing flet.
This PR fixes this.
Signed-off-by: lucasew [email protected]
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.