Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmPackages_18: 18.1.7 -> 18.1.8 #320911

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

RossComputerGuy
Copy link
Member

@RossComputerGuy RossComputerGuy commented Jun 19, 2024

Description of changes

https://github.com/llvm/llvm-project/releases/tag/llvmorg-18.1.8

Best tested with llvmPackages_18.clang

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@RossComputerGuy RossComputerGuy marked this pull request as ready for review June 19, 2024 01:44
Copy link
Contributor

@paparodeo paparodeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@numinit numinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

real    55m31.927s                                                                    
user    0m11.792s                                                                     
sys     0m16.386s  
$ ./result/bin/llc --version
LLVM (https://llvm.org/):
  LLVM version 18.1.8
  Optimized build.
  Default target: x86_64-unknown-linux-gnu
  Host CPU: znver4

@paparodeo
Copy link
Contributor

this should be backported into release-24.05. probably not many rebuilds on that branch as looks like rust just moved to llvm18 on master causing many of the rebuilds

@superherointj superherointj merged commit 1b97618 into NixOS:staging Jun 19, 2024
28 checks passed
@superherointj
Copy link
Contributor

superherointj commented Jun 19, 2024

@RossComputerGuy Keep an eye in Hydra builds, to check for downstream, to see if something unusual happens. (When this goes wrong, it can break a lot of things, you know...)

@RossComputerGuy RossComputerGuy deleted the feat/llvm-18-1-8 branch June 20, 2024 01:13
@RossComputerGuy RossComputerGuy added backport release-24.05 Backport PR automatically labels Jun 20, 2024
Copy link
Contributor

Git push to origin failed for release-24.05 with exitcode 1

Copy link
Contributor

Successfully created backport PR for release-24.05:

@RossComputerGuy
Copy link
Member Author

@paparodeo Forgot to backport lol, I'm adding it now.

@RossComputerGuy RossComputerGuy added backport staging-24.05 Backport PR automatically and removed backport release-24.05 Backport PR automatically labels Jun 20, 2024
Copy link
Contributor

Successfully created backport PR for staging-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants