libbsd: 0.11.8 -> 0.12.2 #320874
Merged
libbsd: 0.11.8 -> 0.12.2 #320874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the existing Darwin patch (which has been unnecessary for several releases) with a new one for a new issue. Closes: NixOS#292228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Replace the existing Darwin patch (which has been unnecessary for several releases) with a new one for a new issue.
Closes: #292228
Tested on macOS with
nixpkgs-review; the only build failure that isn’t already broken on Hydra istermscp, which fails to build locally for me even without this change – probably some sandboxing issue. I would appreciate if someone with more CPU cores than me could test on Linux.Sorry @wegank, I didn’t notice #292228 and your work on it until after I’d finished this; I think this should be a more compatible fix and r-ryantm wiped out your changes.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.