A few misc BSD related cleanups #320840
Merged
A few misc BSD related cleanups #320840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not just FreeBSD.
It is less mature than the other two, but we are in the process of making it better, and caching helps.
The big `fetchCVS` is slow, but a one-time cost. Everything else is much faster, and not having to manage a gazillion `version` and `sha256` fields is much easier. This brings NetBSD in line with how we do FreeBSD and OpenBSD.
13 tasks
rhelmot
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
All of the changes seem to fall into one of two categories:
- new features (to my eye, implemented thoughtfully and maintainably, in many cases copied from the heavily-reviewed FreeBSD code)
- one-to-one changes to take advantage of those new features, and additions/removals of dependencies to match new needs
lgtm!
1 task
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
See each commit for details
Things done
Cross compiled
helloto each BSD.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 馃憤 reaction to pull requests you find important.