Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easytag: fix ogg corruption, darwin build, add maintainer #320833

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

matteo-pacini
Copy link
Contributor

Description of changes

  • Modernised the derivation a bit
  • Borrowed a patch from Gentoo that prevents easytag from corrupting Ogg Vorbis files
  • Builds and works on Darwin too now (tested on aarch64-darwin)
  • Added myself as maintainer (derivation has none)
  • Formatted the derivation with nixfmt-rfc-style (in a separate commit)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@thiagokokada thiagokokada merged commit 971ea0a into NixOS:master Jun 19, 2024
31 checks passed
# https://gitlab.gnome.org/GNOME/easytag/-/merge_requests/8
# Borrowed from Gentoo
(fetchpatch {
url = "https://gitweb.gentoo.org/repo/gentoo.git/plain/media-sound/easytag/files/easytag-2.4.3-ogg-corruption.patch";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this url is not tied to a specific commit of the upstream git repository so the patch can change. Please make another pr with a fixed url, like there:

url = "https://gitweb.gentoo.org/repo/gentoo.git/plain/sys-fs/fuse/files/fuse-2.9.9-closefrom-glibc-2-34.patch?id=8a970396fca7aca2d5a761b8e7a8242f1eef14c9";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@symphorien well spotted, will do!

@matteo-pacini matteo-pacini deleted the easytag-resurrection branch June 21, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants