Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waybar: fix sndioSupportFlag and evdevSupport flags #320789

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Jun 18, 2024

Description of changes

Resolves: #320499

Cava flag is dependent on the sndio flag, will implement a non silent requirement upstream.
Evdevsupport was just missed so it was being expected regardless of flag being unset.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that the assert works by trying to build waybar.override {sndioSupport = false;} and waybar.override {sndioSupport = false; cavaSupport = false;}, everything is as expected. Thanks!


Result of nixpkgs-review pr 320789 run on x86_64-linux 1

1 package built:
  • waybar

@khaneliman khaneliman requested a review from drupol June 19, 2024 14:38
@drupol drupol merged commit ca8f4a1 into NixOS:master Jun 19, 2024
28 checks passed
@khaneliman khaneliman deleted the waybar-fixes branch June 19, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: waybar with evdevSupport = false
4 participants