Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flyctl: 0.2.69 -> 0.2.71 #320705

Merged
merged 2 commits into from
Jun 18, 2024
Merged

flyctl: 0.2.69 -> 0.2.71 #320705

merged 2 commits into from
Jun 18, 2024

Conversation

RaghavSood
Copy link
Member

@RaghavSood RaghavSood commented Jun 18, 2024

Description of changes

superfly/flyctl@v0.2.69...v0.2.71

buildGoDir internally tacks on the tags and other flags we define. For flyctl, this results in a panic in an upstream dependency (specifically, when tags include production, flyctl attempts to report errors to sentry with a insufficiently initialized HTTP transport, resulting in a panic within sentry-go)

There are two upstream issues filed which should resolve this and allow us to go back to using buildGoDir:

superfly/flyctl#3642 - With an accompanying PR superfly/flyctl#3643
getsentry/sentry-go#841

Closes #320658.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@RaghavSood RaghavSood added the backport release-24.05 Backport PR automatically label Jun 18, 2024
@RaghavSood RaghavSood changed the title Flyctl/0.2.71 flyctl: 0.2.69 -> 0.2.71 Jun 18, 2024
@RaghavSood
Copy link
Member Author

All four builds and passthrus work, looks sane

@RaghavSood RaghavSood merged commit 539c2b0 into NixOS:master Jun 18, 2024
29 checks passed
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-320705-to-release-24.05 origin/release-24.05
cd .worktree/backport-320705-to-release-24.05
git switch --create backport-320705-to-release-24.05
git cherry-pick -x 3022e36db0d0a5c0e1e1debdda2ce1336473f1c7 fc0b2f8051b7c9ba161f2a003ce7ee39f8e8c969

@RaghavSood
Copy link
Member Author

Probably needs both this and the previous one to be backported - I'll do it manually

@techknowlogick
Copy link
Member

Thanks @RaghavSood 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: flyctl-0.2.69
2 participants